Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip miri tests if miri setup fails #790

Merged
merged 1 commit into from
May 2, 2019
Merged

skip miri tests if miri setup fails #790

merged 1 commit into from
May 2, 2019

Conversation

RalfJung
Copy link
Contributor

@RalfJung RalfJung commented May 2, 2019

If Miri can be installed but not set-up, that's also a problem with the current nightly and unrelated to rand.

@RalfJung
Copy link
Contributor Author

RalfJung commented May 2, 2019

Also, once rust-lang/rust#60173 lands, with the next nightly the tests should actually run again.

Do you have a nightly cron job set up?

@dhardy
Copy link
Member

dhardy commented May 2, 2019 •
edited
Loading

No, but we usually have enough churn that another run happens soon enough anyway.

Thanks for this.

@dhardy dhardy merged commit 5089309 into rust-random:master May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RalfJung @dhardy